search

Open-Systems-Pharmacology / docs

Open Systems Pharmacology - Live Documentation
https://docs.open-systems-pharmacology.org/
Other
9 stars 16 forks source link

Adding description for residual calculation #214

Closed georgeDaskalakis closed 1 year ago

Yuri05 commented 1 year ago

@georgeDaskalakis Can you fix (s. review comments)? After that we can merge I think

georgeDaskalakis commented 1 year ago

@Yuri05 cade review notes fixed. I still seem to be getting some errors when the tests run: https://github.com/Open-Systems-Pharmacology/docs/actions/runs/3891203461/jobs/6641153449

Yuri05 commented 1 year ago

@georgeDaskalakis All links are valid. 1 Link (below) is correctly reported as invalid, because it's indeed invalid on the level of source markdown files. However it's valid in the final rendered documentation (so apparently GitBook creates here a HTML anchor differently from GitHub). All other links are just false alarms - they are valid both in source MD as well as in the final rendered documentation. Probably some bugs in the link validator whatsoever.

So all good here

In file part-2/modules-philsophy-building-blocks.md
     bad reference (relative) at src:70:112-256:
       - text: "Exporting Project to Snapshot"
       - link: ../part-3/importing-exporting-project-data-models.md
       - anchor: exporting-project-to-snapshot-loading-project-from-snapshot

     ⛀  Anchor 'exporting-project-to-snapshot-loading-project-from-snapshot' is not present,
        did you mean exporting-project-to-snapshot--loading-project-from-snapshot (header II) at src:93:1-64?