search

Open-Systems-Pharmacology / rSharp

R package for communication with .NET Core
http://www.open-systems-pharmacology.org/rSharp/
GNU General Public License v2.0
1 stars 0 forks source link

`rSharp_create_domain` should return a flag #117

Closed PavelBal closed 7 months ago

PavelBal commented 8 months ago

Loading assembly might throw an unhandled exception, which crashes R.

rwmcintosh commented 8 months ago

What branch are you working in? Seems like that should be part of the issue #53 which has been worked on in #112

rwmcintosh commented 8 months ago

But not yet merged

PavelBal commented 8 months ago

Yes working on that branch.

rwmcintosh commented 8 months ago

Ok, when you can reproduce let's see. I expect the title will have to change somehow because we are catching exceptions and returning flags from C# to C++ and then C++ is returning a meaningful SEXP based on the flag.

PavelBal commented 8 months ago
rwmcintosh commented 8 months ago

This came up through a series of unfortunate events, but anyway, if a user does not call rsharp_create_domain, but calls other methods, the exception would happen and we should not crash R process in that event.