search

Open-Systems-Pharmacology / rSharp

R package for communication with .NET Core
http://www.open-systems-pharmacology.org/rSharp/
GNU General Public License v2.0
1 stars 0 forks source link

Fixes #22 C# gha workflow #143

Closed Felixmil closed 6 months ago

Felixmil commented 7 months ago

Fixes #22

image

rwmcintosh commented 6 months ago

I think we have to be observant about this. I believe the tests are not very reliable, but let's start with this.

rwmcintosh commented 6 months ago

Fixes #22

Felixmil commented 6 months ago

R actions should start only after binaries successfully built. Will only work once the C# building workflow is in default branch (cf https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run)

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

Felixmil commented 6 months ago

@rwmcintosh The .so file is apparently not commited during the Linux step: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887856458#step:8:28

However the .dll files are commited during the Windows build: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887924340#step:10:32

rwmcintosh commented 6 months ago

@rwmcintosh The .so file is apparently not commited during the Linux step: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887856458#step:8:28

However the .dll files are commited during the Windows build: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887924340#step:10:32

It could be because gcc builds the binary equivalent when source is unchanged where msvc does not. I will commit a change in the C++ cod to test it today, but then I need to change it back again before merging.

rwmcintosh commented 6 months ago

@rwmcintosh The .so file is apparently not commited during the Linux step: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887856458#step:8:28 However the .dll files are commited during the Windows build: https://github.com/Open-Systems-Pharmacology/rSharp/actions/runs/9059706133/job/24887924340#step:10:32

It could be because gcc builds the binary equivalent when source is unchanged where msvc does not. I will commit a change in the C++ cod to test it today, but then I need to change it back again before merging.

@Felixmil confirmed the above. Changes in cpp source will trigger a commit of .so. All Linux and Windows build/commit is complete.

Felixmil commented 6 months ago

C# binaries are now built by github actions and pushed to repository (in PR branches, before merge)

@PavelBal Can we merge ?

PavelBal commented 6 months ago

Let's try out.