Open-TEE / project

Overall project configuration and documentation
Apache License 2.0
80 stars 35 forks source link

com_msg_request_cancellation operation_id field #9

Open OSFO opened 9 years ago

OSFO commented 9 years ago

Hi, I am having problems getting the TEE_GetCancellationFlag functionality to work.

To me it seems that the operation_id field of the com_msg_request_cancellation is never set - however it is later compared in request_cancel_msg.

Hope I am not terribly of base here...

TanelDettenborn commented 9 years ago

Hi, Our cancellation functionality did work, but it may have been broken. I will look into this problem and getting back to you.

2015-09-16 17:21 GMT+03:00 OSFO notifications@github.com:

Hi, I am having problems getting the TEE_GetCancellationFlag functionality to work.

To me it seems that the operation_id field of the com_msg_request_cancellation is never set - however it is later compared in request_cancel_msg.

Hope I am not terribly of base here...

— Reply to this email directly or view it on GitHub https://github.com/Open-TEE/project/issues/9.

TanelDettenborn commented 9 years ago

You are not at all terribly of base here. You are absolutely right, operation_id filed is not set, but it is used at TA. I have made a patch: https://review.gerrithub.io/#/c/246717/ If the patch is OK, then it is merged into master.

If there is anything else, do not hesitate =)

Sorry about inconvenience.

2015-09-17 12:07 GMT+03:00 Tanel Dettenborn tanel.dettenborn@gmail.com:

Hi, Our cancellation functionality did work, but it may have been broken. I will look into this problem and getting back to you.

2015-09-16 17:21 GMT+03:00 OSFO notifications@github.com:

Hi, I am having problems getting the TEE_GetCancellationFlag functionality to work.

To me it seems that the operation_id field of the com_msg_request_cancellation is never set - however it is later compared in request_cancel_msg.

Hope I am not terribly of base here...

— Reply to this email directly or view it on GitHub https://github.com/Open-TEE/project/issues/9.

OSFO commented 9 years ago

Works great - thanks!

You guys are fast as lightening...