Improve the CSV upload interface

duncandewhurst commented 2 years ago

CSV is the tabular publication format for OFDS data (rather than Excel) so we need to support validating multiple CSV files.

The following Flatten Tool command generates the desired JSON file when run against the example CSV files:

flatten-tool unflatten examples/csv -s schema/network-schema.json -m networks -f csv -o test.json

duncandewhurst commented 2 years ago

I've done some testing with the CSV files in the examples/csv directory of the standard repository (results). Generally, looks good, but a few things to update:

The CSV upload interface is awkward. It involves a lot of clicking to upload multiple CSV files and there aren't enough boxes to upload all the CSV files in the examples/csv directory of the standard repository. Can we have a single 'Browse' button that opens a dialog in which the user can select multiple files? If not, can we have a single browse button that the user can click as many times as they want to add multiple files?

There are many validation errors. It looks like the conversion from CSV to JSON is not schema-aware. When I submit the test.json file generated by the Flatten Tool command in the issue description I get only one error (results).
In both the upload interface and the results interface, replace 'CSVs' with 'CSV'.
Add a URL option to the upload interface. It can either be one text box that accepts a single URL with a button that the user can click multiple times to add multiple URLs (preferred option), or it can be a single text box that accepts a comma-separated list of URLs.

odscjames commented 2 years ago

The CSV upload interface is awkward.

Was a first pass - it would also be really neat to have one of those "drag and drop" things too.

It looks like the conversion from CSV to JSON is not schema-aware.

Was waiting for schema ref 404 to be fixed - on 2022-11-08 now

In both the upload interface and the results interface, replace 'CSVs' with 'CSV'.

on 2022-11-08 now

duncandewhurst commented 2 years ago

The changes on 2022-11-08 look good.

The priority outstanding action for this issue is updating the upload interface with one of the options suggested in my previous comment.

odscjames commented 2 years ago

"The priority outstanding action for this issue" means "The CSV upload interface is awkward"?

duncandewhurst commented 2 years ago

Yes - the two options suggested to fix it in that bullet point.

Open-Telecoms-Data / cove-ofds

Improve the CSV upload interface #15