Open-Telecoms-Data / cove-ofds

https://ofds.cove.opendataservices.coop/
Other
1 stars 0 forks source link

Additional fields: Report examples and child fields (add quotes to string values, copy-edits) #20

Open duncandewhurst opened 2 years ago

duncandewhurst commented 2 years ago

The OCDS DRT reports examples for each additional field and has a modal pop-up to show children of additional fields. Please can we add these features to OFDS CoVE?

Example image

duncandewhurst commented 2 years ago

Related to https://github.com/Open-Telecoms-Data/lib-cove-ofds/issues/4

Also:

Your data contains additional fields that are not part of the OFDS schema. You should:

  • Check that additional fields are not the result of typos in field names or other errors in your mapping or data pipeline.
  • Check whether the data in these fields could be provided by using a field in the OFDS schema
  • Document the structure, format and meaning of additional fields in your data user guide.
duncandewhurst commented 2 years ago

The first two checklist items are done in 536a9513659d01ace125b722ab4a350dba962735

odscjames commented 2 years ago

Last commit adds more info - when available, need to update template in cove in line with https://github.com/OpenDataServices/lib-cove-web/blob/bd849fcd6845b746a80b37d57675e468cdeefefc/cove/templates/additional_fields_table_all.html#L41

odscjames commented 1 year ago

Ready for testing on live

duncandewhurst commented 1 year ago

Looks good, thanks!

Just a couple of minor things:

Image

Edit: I've renamed the issue to reflect the outstanding tasks.

odscjames commented 1 year ago

Additional fields table: 'Occurences' -> 'Occurrences' Child fields table: 'Usage Count' -> 'Occurrences'

Ready for testing on live.

duncandewhurst commented 1 year ago

Looks good. Thanks!