search

Open-Telecoms-Data / cove-ofds

https://ofds.cove.opendataservices.coop/
Other
1 stars 0 forks source link

Spreadsheet converts to empty list of networks #95

Open Bjwebb opened 1 year ago

Bjwebb commented 1 year ago

data.xlsx

http://openfibrecove-build-lxml.dokkudev3.ods.mobi/data/929ae69a-1b97-4730-8e1b-b63b9de684ee

duncandewhurst commented 1 year ago

Hmm, the issue occurs on the live version, too: https://ofds.cove.opendataservices.coop/data/99c71809-d53e-4416-9342-3da36f9e1456

@odscjames please could you investigate? If possible, we should implement tests to catch this type of issue.

odscjames commented 1 year ago

Also noting the UI claims the original data is a CSV file and not the Excel file

duncandewhurst commented 1 year ago

This was definitely working in the past because I was using CoVE to convert the spreadsheets that I created using https://github.com/Open-Telecoms-Data/ofds_qgis_template into JSON files.

odscjames commented 1 year ago

It's not the latest security changes Ben did tho - tested locally and commit c807233321b24c918dfcbaa659097aab62d0a885 still broken

odscjames commented 1 year ago

Fix now live! Leaving open so can look at test comment.

duncandewhurst commented 1 year ago

Confirming that this is working on live. Thanks!