Open-Telecoms-Data / lib-cove-ofds

Other
0 stars 0 forks source link

python checks: data cleaning #36

Closed odscjames closed 2 years ago

odscjames commented 2 years ago

Uploading https://github.com/Open-Telecoms-Data/lib-cove-ofds/blob/main/tests/fixtures/jsonschemavalidate/basic_1.input.json to cove crashes it.

class NodesLocationAndSpansRouteAdditionalCheckForNetwork(AdditionalCheckForNetwork):
    def check_node_first_pass(self, node: dict):
        location = node.get("location")
        if location:
            type = location.get("type")

'str' object has no attribute 'get'

odscjames commented 2 years ago

On live - I've tested - as I reported I'm going to close