search

Open-Telecoms-Data / ofds_consolidation_tool

A tool to consolidate multiple data sets formatted using the Open Fibre Data Standard
https://open-telecoms-data.github.io/ofds_consolidation_tool/
GNU General Public License v3.0
1 stars 0 forks source link

Multiple matches? #15

Closed rhiaro closed 4 months ago

rhiaro commented 8 months ago

What if one node/span from network A matches several nodes/spans from network B? At the moment this is ‘first come first served’

rhiaro commented 7 months ago

https://github.com/Open-Telecoms-Data/ofds_consolidation_tool/pull/30 prevents the user from making multiple matches on the same node

R2ZER0 commented 7 months ago

At the moment, we have the assumption that individual input networks are already de-duplicated - but if the user tried to dedup 3 (or more) nodes, then 2 (or more) of those nodes would have to come from the same network - which implies that the input network wasn't already de-duplicated.

So I think In order to support multi-matching, we'd have to do away with the assumption that input networks are already de-duplicated. Then that means, we could also theoretically run the tool with just one network, de-duplicating within itsself.

I think it would be possible to implement in future, but then we'd need to do more generalised matching than just between two networks?