search

Open-Telecoms-Data / open-fibre-data-standard

Open Fibre Data Standard
https://open-fibre-data-standard.readthedocs.io
Other
14 stars 3 forks source link

Precommit: Use https://pre-commit.com/ instead? #225

Open odscjames opened 1 year ago

odscjames commented 1 year ago

Split out from https://github.com/Open-Telecoms-Data/open-fibre-data-standard/issues/19

odscjames commented 1 year ago

Note https://pre-commit.com/ is a Python tool

And https://pre-commit.ci/ is their CI offering

We can use just the former (via GH Actions) or both.

I've had a quick look and I think some conversion work will be needed, due to it's model of running precommit functions from other repos - (eg black, isort). That makes sense in a lot of cases (eg black, isort) but we also want to run precommit functions from this repo, and I haven't yet seen an easy way to do this. So this won't be a fast conversion, and thus I'll leave it for now.

odscjames commented 1 year ago

Found it: https://pre-commit.com/#repository-local-hooks