search

Open-Wine-Components / umu-launcher

GNU General Public License v3.0
1.75k stars 32 forks source link

Feature request: provide package files directly, not as zip files #271

Open alterNERDtive opened 6 days ago

alterNERDtive commented 6 days ago

I noticed that for the last couple releases the various distribution packages have come zipped up instead of the “naked” packages being attached to the release.

I’m assuming there is a reason for it, but running dnf install <url> is way more convenient than downloading an archive, unpacking it, and only then installing it :)

GloriousEggroll commented 5 days ago

its because thats how github's workflows attach artifacts. we don't really have control/an easy solution for that without some heavy customization of artifact attachments, which is beyond my knowledge atm.

alterNERDtive commented 5 days ago

You should be able to attach arbitrary files. As in, save it from the build workflow, then download in the release workflow.

Obviously I have no idea what you guys’ workflow is in general and if that’s feasible or if you have some other constraints.

GloriousEggroll commented 5 days ago

You should be able to attach arbitrary files. As in, save it from the build workflow, then download in the release workflow.

Obviously I have no idea what you guys’ workflow is in general and if that’s feasible or if you have some other constraints.

I tried this once before and was not successful. Our workflow files are here: https://github.com/Open-Wine-Components/umu-launcher/tree/main/.github/workflows

R1kaB3rN commented 5 days ago

The constraint we're dealing with is specifically with Github's upload artifact workflow. See https://github.com/actions/upload-artifact/issues/426.

I don't see this as a big problem, but if users want the "naked" resources, then they must use the Github API. However, if we want to change this and continue to have things automated, one way if is to automate the Github release and use the github-cli to upload the naked resource.