search

Open-Wine-Components / umu-protonfixes

BSD 2-Clause "Simplified" License
55 stars 31 forks source link

Additional rationale for UPlay fixes #102

Open Tiagoquix opened 1 month ago

Tiagoquix commented 1 month ago

@R1kaB3rN Hello!

I have additional comments about #94:

I agree with your resolution and I believe we should, then, never disable UPlay overlay by default, no matter which game.

Why?

Because UPlay problems are universal. The launcher itself is always the same: if it works wonderfully in one game, it also works wonderfully in others. If it works horribly in one game, it also works horribly in others. It's the same logic as the Steam Client In-Game Overlay.

With the reasoning that we should always prioritize not losing features in certain games, I believe that we should then allow the user to disable the Ubisoft overlay if they wish, but protonfixes should not do that. As I see it, protonfixes, then, should only add things that are necessary to make the game playable, and not just because it makes them better.

For instance, think about old Rockstar Games. Many of them have a mod called "SilentPatch", to fix various game issues, yet it is not absolutely necessary to play the game. You can still play the game without it, but in a very inferior state.

While in some games the UPlay overlay can cause performance and input problems, the game is still playable even with these problems (even if it's in a degraded state).

To conclude, I suggest we remove any game fix related to disabling the UPlay overlay by default.

The best alternative I can think is to add an env. variable (runtime option) exclusive to Proton-GE called PROTON_GE_DISABLE_UPLAY_OVERLAY or something like that to make it easy for users to disable UPlay overlay.

I'm also fine if the env. variable is not added and we just remove the UPlay overlay-related fixes and call it a day.

Thanks for your attention.

Tiagoquix commented 1 month ago

Additionally, the same rationale can also be applied to the Electronic Arts (EA Desktop App and origin) overlay. And also for any relevant overlay out there.

I don't think we have any fix related to overlays apart from the Ubisoft one.