Open-Wine-Components / umu-protonfixes

BSD 2-Clause "Simplified" License
58 stars 32 forks source link

Add fixes for COJ Gunslinger on Steam #75

Closed Tiagoquix closed 4 months ago

Tiagoquix commented 4 months ago

Please let me know if I missed something. Thanks!

wmp11 and 31 cores fixes are due to user reports:

https://github.com/ValveSoftware/Proton/issues/366

https://www.protondb.com/app/204450

It seems like both wmp9 and wmp11 work, so we should prefer the newer version. I am using wmp11 and it works normally.

Tiagoquix commented 4 months ago

@R1kaB3rN Hi there. Could you please clarify for me if the following is needed for future contributions? Thanks in advance.

#pylint: disable=C0103

from protonfixes import util
R1kaB3rN commented 4 months ago

@R1kaB3rN Hi there. Could you please clarify for me if the following is needed for future contributions? Thanks in advance.

#pylint: disable=C0103

from protonfixes import util

The first statement is not strictly necessary when it comes to applying fixes, so users shouldn't need to worry about it.

As for the second statement, it depends but you will most likely need it to do anything useful since all the functionality to apply a fix are currently in that file.