search

Open-Wine-Components / umu-protonfixes

Other
48 stars 31 forks source link

Add UPlay fix to all UPlay-enabled titles #90

Closed Tiagoquix closed 2 weeks ago

Tiagoquix commented 1 month ago

This is the list of all games that could benefit from the UPlay overlay disable function:

https://steamdb.info/tech/Launcher/Ubisoft/

Would be nice to include all of the games here with the function.

R1kaB3rN commented 1 month ago

For this to scale, there would need to be a public API that will list all current games with Ubisoft launchers. Otherwise, we would need to do what Valve does and manually add IDs in the program which I am opposed to doing. If we can find an endpoint that will list them, then perhaps we can autogenerate fixes for those games that will disable the overlay.

Tiagoquix commented 1 month ago

I can manually add it to some more famous and "relevant" games, but I don't know if that would be really desireable, as it would be treadmill work.

As you said, we would have to see if there is some solution to autogenerate, along with an API. I imagine we could contact the owner of SteamDB.info so they can provide such data in an API-friendly format, but I'm not sure if that would even be possible. Their GitHub is https://github.com/xPaw.

R1kaB3rN commented 1 month ago

I won't stop you from doing that, but I would just let users create a fix for them if they really want it. Also, asking the creators of steamdb to provide us API access won't work because the creators encourage users to acquire Steam data directly from Steam or to use SteamKit.

Besides Steam there are other stores to consider as well that may provide access to this metadata from their API (e.g., GOG).

R1kaB3rN commented 2 weeks ago

Closing. See https://github.com/Open-Wine-Components/umu-protonfixes/pull/94#issuecomment-2282246528 for rationale.

Feel free to reopen if you disagree or if you know of a way to both precisely and reliably determine at runtime whether the loss of functionality as a result of disabling the overlay would cause or not cause any issues.