search

Open-Xchange-Frontend / shared-grunt-config

This shared configuration can be used to develop modules for the Open-Xchange Appsuite UI
MIT License
1 stars 2 forks source link

Please support symlinks in build_apps task #11

Open binarykitchen opened 2 years ago

binarykitchen commented 2 years ago

We've got images symlinked to another folder but the grunt build_apps task seems not to include these. This causes errors in our appsuite and 404 errors in browser.

After some research it seems that follow: true is missing, raised in: https://github.com/gruntjs/grunt-contrib-copy/issues/276

And it's missing here in your code: https://github.com/Open-Xchange-Frontend/shared-grunt-config/blob/master/tasks/shared/copy.js#L40

I recall we didn't have that problem with an older appsuite/grunt config version but this behaviour seems to have changed recently with an update I couldn't narrow down yet.

Point is, the image should exist on both sides, as an original and where it is symlinked. It seems it only copies the symlink but ignored its original location.

Hard to say, I see the copy task hasn't changed since 2014. Just raising here in the hope someone else can jump in and advice. Thanks.

binarykitchen commented 2 years ago

I can confirm that using follow: true fixed it for me. Still, I recommend this to exist in the default config.