Open3DMotionGroup / Open3DMotion

Other
5 stars 2 forks source link

Two unit tests fail under MacOS X 10.9 #11

Closed Alzathar closed 10 years ago

Alzathar commented 10 years ago

After applying the pull requests #9 and #10, I still have two unit tests which failed:

The full log is:

/Users/alzathar/Code/Open3DMotion.git/src/Open3DMotionTest/OpenORM/IO/TestBSON.cpp:142: Assertion
Test name: TestBSON::testStreamSkipBytes
forced failure
- expected BSONReadException when skipping past end of data

/Users/alzathar/Code/Open3DMotion.git/src/Open3DMotionTest/Biomechanics/Algorithms/MOSHFIT/TestRigidBodyShapeCollection.cpp:636: Assertion
Test name: TestRigidBodyShapeCollection::testComputeMeanShape
double equality assertion failed
- Expected: 0
- Actual  : 0.101863292697704
- Delta   : 0.1
Alzathar commented 10 years ago

Under Ubuntu 12.04 only one test failed

TestRigidBodyShapeCollection.cpp:640:Assertion
Test name: TestRigidBodyShapeCollection::testComputeMeanShape
double equality assertion failed
- Expected: 0
- Actual  : 0.110541159656257
- Delta   : 0.1

Even after applying the pull request #12 under MacOS X, the same unit tests fail again.

drjrm commented 10 years ago

Many thanks for the feedback. Now fixed in master, commits 21033cdb1a88eff954a5909ce6355999a677815e and 38a7a747e8dda218686a2819dca95b071872ab3a. The fix for TestBSON::testStreamSkipBytes is a workaround for inconsistent behaviour in STL stringstream between OSX clang and all other compilers used.