search

OpenAADL / fmu2aadl

FMI to AADL conversion toolchain
Eclipse Public License 1.0
1 stars 2 forks source link

FMU input/outputs matching AADL reference keywords #3

Closed svenTeum closed 4 years ago

svenTeum commented 6 years ago

If I have for example an FMU with an input called reference, fmu2aadl generates the corresponding AADL files but the name of the input is still reference

Then the resulting model can't be compiled with Ocarina since reference is an AADL keyword and the file parsing fails.

fmu2aadl may at least show a warning about that issue so the user can modify the FMU.

yoogx commented 6 years ago

You're right, there should be a mechanism to explicitly forbid this. I see two options (related to your other issues)

a) forbid the inclusion of such FMU. Easy, but worthless, as we should not reject FMU based on such name

b) propose a rewrite strategy for names to avoid such situation. An easy option would be simply to have as a rule to prefix every name from the FMU with a prefix like

FMI_<in|out>param

I'll implement b) when time permits.