OpenACalendar / OpenACalendar-Web-Core

OpenACalendar Web Site - Core System
Other
16 stars 11 forks source link

404 page template should extend pageMinimal #661

Closed jarofgreen closed 8 years ago

jarofgreen commented 8 years ago

https://github.com/OpenACalendar/OpenACalendar-Web-Core/blob/master/core/theme/default/templates/site/pageMinimal.html.twig https://github.com/OpenACalendar/OpenACalendar-Web-Core/blob/master/core/theme/default/templates/site/error404.html.twig

This will expose some bugs tho, when the user goes to /404.php - the template will expect some variables the php will not set.

Maybe we should retire 404.php and serve 404 through the main twig loop - this will give full flexibility to theme designers.