OpenAIM / OpenRFA-Website

Crowdsourced standard Revit shared parameters with tools for improved collaboration.
http://openrfa.org
8 stars 3 forks source link

Add login authentication module #18

Closed vdubya closed 5 years ago

vdubya commented 5 years ago

Minimize friction to account creation. LinkedIn authentication particularly interesting due to professional networking emphasis. Other authentication methods are fine as well, whatever is easiest to implement with an existing Drupal module.

jmerlan commented 5 years ago

I tested this module a year ago and it wouldn't work. There have been some updates to Drupal so perhaps it will work now. I'll give it a shot and report back.

jmerlan commented 5 years ago

Still having issues: http://openrfa.org/admin/reports/event/402394

Error message: Notice: Trying to get property of non-object in _hybridauth_user_login_access_by_uid() (line 1170 of /home/openrfa/public_html/openrfa/sites/all/modules/hybridauth/hybridauth.module).

vdubya commented 5 years ago

Are there other authentication module options?

vdubya commented 5 years ago

@jmerlan Maybe you could give this GitHub authentication module a try? https://www.drupal.org/project/github_connect

jmerlan commented 5 years ago

I don't think most of our users have a GitHub account. Let me try out Google/Twitter/Facebook and see if I can at least get those to work. I've gotten them to work in the past.

vdubya commented 5 years ago

I agree that most of our users probably don’t have a github account but I think we REALLY want to encourage it. Plus if we were able to get github and LinkedIn it would be a really good way to reduce spambots.

jmerlan commented 5 years ago

I have the OneAll module that works installed to the dev site. @vdubya, please test it and I can roll it out to the production site. There are several social media sites that it supports, but I've only enable LinkedIn and GitHub for now.

vdubya commented 5 years ago

@jmerlan Tested, works and looks fantastic!! Feedback:

2018-10-10 13_51_49-authorize application

jmerlan commented 5 years ago

@vdubya It appears as though you can't request authorization from an organization: https://stackoverflow.com/questions/31159275/how-do-i-generate-the-github-oauth-token-for-organization-accounts

Can you confirm? Should we create a dummy Github users that is called OSAIC or something?

vdubya commented 5 years ago

@jmerlan Yes, a machine account would be good, probably one specifically called OpenRFA would be the most identifiable (or OpenRFA-bot, OpenRFA-Admin, or something).

jmerlan commented 5 years ago

Thanks for the link. I'll set that up. I'm thinking we name it after OSAIC so that it can be the machine account for the entire organization.

vdubya commented 5 years ago

Closing because I think it is good for v1 implementation, and we can focus on the account merging/association question as a separate issue. Of course reopen if you disagree!