search

OpenAMP / libmetal

An abstraction layer across RTOS, baremetal, and user-space Linux environments
https://www.openampproject.org/
Other
262 stars 170 forks source link

Wrap vars ifndef #236

Closed bentheredonethat closed 1 year ago

bentheredonethat commented 1 year ago

Enable demos to be configured via CMake configure or toolchain file.

This enables the demos to be configured for Versal and Versal_Net platforms.

bentheredonethat commented 1 year ago

Hi @arnopo @edmooring

the error here does not seem to apply to the patches given. please review the set when able.

this makes it so we can configure the apps via cmake and thus the demos more scalable.

i understand there is a pending move to system-reference repo for apps. since the apps have not yet been moved, can we review and merge here first and then at the time of the move we can then begin to send patches to the new repo?

thanks

kernelchuk commented 1 year ago

Ben, @TanmayShah-xilinx,

This PR contradicts two decisions:

  1. Our plan to use a (re-)generated file for IPI*, SHM, TTC_, etc. values.
  2. This https://github.com/OpenAMP/libmetal/pull/231#issuecomment-1499325357 about changes in the example code.
bentheredonethat commented 1 year ago

closing for now