search

OpenAMP / libmetal

An abstraction layer across RTOS, baremetal, and user-space Linux environments
https://www.openampproject.org/
Other
262 stars 170 forks source link

lib: remove MB and GB definition in utilities.h #242

Closed arnopo closed 1 year ago

arnopo commented 1 year ago

The introduction of MB and GB macros introduces warnings in Zephyr build. Indeed they are already defined in zephyr/include/zephyr/sys/util.h. Remove them and put them back in lib/system/generic/xlnx_common/zynqmp_aarch64/sys.c.

arnopo commented 1 year ago

@bentheredonethat: This PR fix #237. Please, could you confirm that it works on your side

bentheredonethat commented 1 year ago

@arnopo confirmed

bentheredonethat commented 1 year ago

Hi @arnopo I would actually push back on this patch

for ports where we have support for multiple processors (which we plan to upstream) then we would have to revert this patch because multiple processors would use the MB/GB symbols.

CC @tnmysh

arnopo commented 1 year ago

Hi @arnopo I would actually push back on this patch

for ports where we have support for multiple processors (which we plan to upstream) then we would have to revert this patch because multiple processors would use the MB/GB symbols.

CC @tnmysh

Hi @bentheredonethat Could I merge this one or do you plan to provide a better fix in a the short term?

tnmysh commented 1 year ago

Hi @arnopo I would actually push back on this patch for ports where we have support for multiple processors (which we plan to upstream) then we would have to revert this patch because multiple processors would use the MB/GB symbols. CC @tnmysh

Hi @bentheredonethat Could I merge this one or do you plan to provide a better fix in a the short term?

@arnopo I will provide fix.

tnmysh commented 1 year ago

@arnopo @bentheredonethat done: https://github.com/OpenAMP/libmetal/pull/249/