search

OpenAMP / meta-openamp

Yocto/OE meta layer to add OpenAMP support to your BSP or distro
MIT License
51 stars 33 forks source link

vendor/xilinx: meta-xilinx-standalone-experimental: Update to work wi… #33

Closed bentheredonethat closed 1 year ago

bentheredonethat commented 1 year ago

…th latest sources

As there has been a re-structuring of meta-openamp, there was a regression in support. This patch ensures that using latest SDT and OpenAMP overlays works with latest Lopper to generate OpenAMP DTs and apps for Versal and ZU+

additionally alo provide some formatting fixes in the recipes

mhatle commented 1 year ago

I've reviewed the changes. They are specific to this vendor implementation so any risk of merging is very low, as only a specific configuration is affected. As noted, the current implementation doesn't actually work.. which lowers the risk further.

bentheredonethat commented 1 year ago

ping @wmamills @edmooring @TanmayShah-xilinx for review

bentheredonethat commented 1 year ago

@arnopo @wmamills @edmooring ping for review

just trying to make sure a non AMD-Xilinx person reviews this.

Thank you

wmamills commented 1 year ago

I have tested the generic (non Xilinx) build w/ and w/o this commit and nothing gets rebuilt so I think that guarantees this is harmless for non-xilinx builds. If you are happy with it, it is OK to merge.