OpenAPITools / jackson-databind-nullable

JsonNullable wrapper class and Jackson module to support meaningful null values
Apache License 2.0
103 stars 30 forks source link

Fix broken unwrap bean validation and adapt tests #50

Closed MelleD closed 1 year ago

MelleD commented 1 year ago

@tofi86 @wing328

49

MelleD commented 1 year ago

Any chance to return the index of the invalid item in the persons collection as it was until now?

No how i said it's normal behavior of bean validation into a Set

tofi86 commented 1 year ago

@MelleD Thanks for your quick feedback. I wasn't aware of Set validation not returning the invalid index. I guess I'm fine with that then! :-)

tofi86 commented 1 year ago

At least we got the index for List ;-)

MelleD commented 1 year ago

At least we got the index for List ;-)

:)

wing328 commented 1 year ago

if no further feedback, I'll merge it over the weekend and cut a release next week?

wing328 commented 1 year ago

Thanks for the PR, which has been merged. Will try to cut a release tomorrow.

wing328 commented 1 year ago

Released:

[INFO]  * Upload of locally staged artifacts finished.
[INFO]  * Closing staging repository with ID "orgopenapitools-1298".

Waiting for operation to complete...
.........

[INFO] Remote staged 1 repositories, finished with success.
[INFO] Remote staging repositories are being released...

Waiting for operation to complete...
......

[INFO] Remote staging repositories released.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:27 min
[INFO] Finished at: 2023-02-21T14:34:56+08:00
[INFO] ------------------------------------------------------------------------

It may take sometime for the new release to be visible in https://search.maven.org