bugfix (to master): after openapi specs comparison, all parameters are removed

justinasbardauskas commented 1 year ago

bugfix: after openapi specs comparison, all parameters are removed from new spec (right side) because of reused parameters list.

updated code to use copy of given parameters list in diff method. Root cause (before fix) https://github.com/OpenAPITools/openapi-diff/blob/f595a84b9620d2ea65a9b0b71364810e4e3003d4/core/src/main/java/org/openapitools/openapidiff/core/compare/ParametersDiff.java#L66
added few tests to cover this case

Issue affects 2.0.x and master branches. Ports

to 2.0.x: https://github.com/OpenAPITools/openapi-diff/pull/453
to master: https://github.com/OpenAPITools/openapi-diff/pull/454

gitpod-io[bot] commented 1 year ago

justinasbardauskas commented 1 year ago

joschi I found a bug where after comparison request parameters are removed from "new spec" OpenAPI object, because in the diff method list.remove(...) method was used on original list (method argument). I created PR to master and 2.0.x branches. Please review, thanks.

OpenAPITools / openapi-diff

bugfix (to master): after openapi specs comparison, all parameters are removed #454