search

OpenAPITools / openapi-diff

Utility for comparing two OpenAPI specifications.
Apache License 2.0
780 stars 153 forks source link

Valid plugin declaration in README.md #553

Closed AndrewVolostnykh closed 6 months ago

AndrewVolostnykh commented 11 months ago

Configuration block replaced from execution to plugin

joschi commented 11 months ago

@AndrewVolostnykh Could you please elaborate on why you think the current example is invalid?

executions: It is important to keep in mind that a plugin may have multiple goals. Each goal may have a separate configuration, possibly even binding a plugin's goal to a different phase altogether. executions configure the execution of a plugin's goals.

https://maven.apache.org/pom.html#plugins

AndrewVolostnykh commented 11 months ago

@AndrewVolostnykh Could you please elaborate on why you think the current example is invalid?

executions: It is important to keep in mind that a plugin may have multiple goals. Each goal may have a separate configuration, possibly even binding a plugin's goal to a different phase altogether. executions configure the execution of a plugin's goals.

https://maven.apache.org/pom.html#plugins

Thank you for review. When I tried to execute the current implementation of the plugin - none of the configurated parameters has been used by the plugin. Only one solution helped is to move the configuration block to the plugin section. Maybe this case needs deeper investigation