search

OpenAPITools / openapi-generator-bazel

Bazel plugin for OpenAPI Generator
Apache License 2.0
66 stars 48 forks source link

Change from native.maven_jar to jvm_maven_import_external #10

Closed acidmoose closed 3 years ago

acidmoose commented 4 years ago

Tested build with bazel 1.1.0 and 2.2.0 on OSX. With this change the 2.2.0 build no longer fails and 1.1.0 still seem to build without issues.

wing328 commented 4 years ago

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

acidmoose commented 4 years ago

Thanks, didn't even notice I used that email. I've added that email to my profile.

wing328 commented 4 years ago

@mrmeku are you happy with the change?

skmgoldin commented 4 years ago

Bazel 2 support would be nice!

dududko commented 4 years ago

Any update on this PR ?

wing328 commented 4 years ago

@acidmoose thanks again for the PR. Can you please PM me via https://join.slack.com/t/openapi-generator/shared_invite/enQtNzAyNDMyOTU0OTE1LTY5ZDBiNDI5NzI5ZjQ1Y2E5OWVjMjZkYzY1ZGM2MWQ4YWFjMzcyNDY5MGI4NjQxNDBiMTlmZTc5NjY2ZTQ5MGM to discuss this PR? Thanks.

eadlam commented 4 years ago

Any updates here?

acidmoose commented 4 years ago

@wing328 see https://github.com/OpenAPITools/openapi-generator-bazel/issues/9 recent comment by @ajc-contribs, as I just made it compile, but he seem to have more of what I was lacking (we have since gone for another approach so I'm no longer using this, but I'll keep the branch up as long as needed).

oneajc commented 4 years ago

@acidmoose, I ended up redoing the work and have forked directly from master. I am downloading opencli.jar from outside and supplying the maven namespace as a param. I do have the jar creation logic intact if someone wants to use.

wing328 commented 4 years ago

@ajc-contribs can you please PM me via Slack? Thank you.