search

OpenAPITools / openapi-generator-bazel

Bazel plugin for OpenAPI Generator
Apache License 2.0
66 stars 48 forks source link

Add support for custom templates #40

Open dotxoa opened 1 year ago

dotxoa commented 1 year ago

It tries to solve this issue.

I have doubts about how to get the template folder path in the right way. Right now I am picking the first file of the folder and the get its path, but this will fail in the case that the folder is empty.

https://github.com/OpenAPITools/openapi-generator-bazel/pull/40/files#diff-c1d432311512e669de77c6dfc7da138be54d44e9646442e1d223e9a4a138ab5cR73

dotxoa commented 1 year ago

@wing328 can you take a look to this?

wing328 commented 1 year ago

thanks for the PR 👍

Can you please PM me via Slack when you've time to have a quick chat (IM) on this?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

wing328 commented 1 year ago

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account