search

OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
https://openapi-generator.tech
Apache License 2.0
21.86k stars 6.59k forks source link

wrong ngPackagr version for angular6 #1615

Closed dominikg closed 5 years ago

dominikg commented 5 years ago

The pr (https://github.com/OpenAPITools/openapi-generator/pull/1613) that added angular7 support (thank you for this, came here to report an issue about it!) added the following code: https://github.com/OpenAPITools/openapi-generator/blob/10ea00066a51df8613488318747bd31dcb92a736/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptAngularClientCodegen.java#L264-L275

The check in line 265 should test for angular version 7.0.0, right? (otherwise the block starting at line 270 is unreachable)

wing328 commented 5 years ago

Make sense to me. Let me file a PR.

wing328 commented 5 years ago

@dominikg I've filed https://github.com/OpenAPITools/openapi-generator/pull/1616. Can you check to see if it looks good to you?

dominikg commented 5 years ago

looks good to me. @pkainz what do you think?

wing328 commented 5 years ago

@dominikg @pkainz the fix has been merged into master. Please pull the latest to give it another try.

pkainz commented 5 years ago

Yes, that's a typo and should read 7.0.0 - thanks for fixing!