Closed jeandonaldroselin closed 3 months ago
@jeandonaldroselin can you merge the most recent master and fix the CI issues if they still occur?
@jeandonaldroselin can you merge the most recent master and fix the CI issues if they still occur?
Hello @macjohnny, I will check the state ASAP and push the changes 👍🏽
@jeandonaldroselin can you merge the most recent master and fix the CI issues if they still occur?
Hello @macjohnny,
Sorry I was busy a lot since last week. I updated my PR with the latest master and updated the tests. The related build just passed :).
Please can you have a look at it ?
PR checklist
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)Please review my PR : @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka