OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
[X] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
(For Windows users, please run the script in Git BASH)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
[X] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
[X] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
I've added two missing ) to the template found in modules/openapi-generator/src/main/resources/kotlin-spring/pathParams.mustache.
In the issue #18854 there is an example openapi.yaml linked in a Gist, which can be used to generate a now compileable Kotlin class.
I ran the above commands for generating samples and docs, but this didn't change any files (I guess this particular use case is not covered in the current examples).
A small note: In the issue linked, I provided suggestion for a fix, which closely resembles the changes in this PR - but not quite. I believe that my first suggestion was not quite right, and this PR has the )'s in the correct places.
Mentions at the Kotlin "Members of Technical Committee":
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier
Fixes #18854
PR checklist
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)I've added two missing ) to the template found in
modules/openapi-generator/src/main/resources/kotlin-spring/pathParams.mustache
.In the issue #18854 there is an example
openapi.yaml
linked in a Gist, which can be used to generate a now compileable Kotlin class.I ran the above commands for generating samples and docs, but this didn't change any files (I guess this particular use case is not covered in the current examples).
A small note: In the issue linked, I provided suggestion for a fix, which closely resembles the changes in this PR - but not quite. I believe that my first suggestion was not quite right, and this PR has the )'s in the correct places.
Mentions at the Kotlin "Members of Technical Committee": @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier