Closed Philzen closed 2 weeks ago
Hey @chschu! Sorry for this being held up for so long... i've now finally got around to open this PR.
Following our discussions, could you briefly review this and see if you have anything to add? Would be looking forward to your feedback, and otherwise these fixes finally hitting the 7.7 release :)
@wing328 if you have some time at the weekend i'd highly appreciate this PR going into v7.7 if possible.
I haven't heard back from @chschu which is co-author of this fix (which actually kickstarted my contributions here as it pointed me into the right direction), but from our discussion over at #18392 they seemed already pretty satisfied at the time.
thanks for the PR, which has been merged.
Hi @Philzen, it seems this PR broke the java-camel samples.
openapi-generator\samples\server\petstore\java-camel> mvn clean verify
results in several failed tests.
Coud you have a look at this?
Closes #2417 Closes #3223 Closes #5078 Closes #18869
Replaces #18392
PR checklist
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)