avoid setting debug property if not needed

ZeeD commented 4 weeks ago

this pr add an optional boolean flag to enable / disable / keep as it is the debug property fixes #18871

@cbornet @tomplus @krjakbrjak @fa0311 @multani

[x] Read the contribution guidelines.
[x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
[x] Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
```
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
[x] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
[x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

wing328 commented 4 weeks ago

thanks for the PR. please follow step 3 to update the samples so that the CI can verify the change.

ZeeD commented 4 weeks ago

updated the samples

ZeeD commented 3 weeks ago

Hi. may someone have a look at the changes?

wing328 commented 3 weeks ago

can you please review the test failures when you've time?

ZeeD commented 3 weeks ago

Oh, it was the fact that bool | None was not supported in python 3.7. switched to Optional[bool]

wing328 commented 3 weeks ago

that's ok.

all tests passed. thanks again for the PR.

if no one has further feedback on this PR, i'll merge it later this week.

ZeeD commented 2 weeks ago

Updated the pr to add explicit check the behavior on the various values you can pass to the constructor

ZeeD commented 2 weeks ago

I was just wondering if there is anything else to do on my side.

multani commented 2 weeks ago

@wing328 can you check this pull request? It's good to merge for me :+1:

wing328 commented 2 weeks ago

@multani thanks for reviewing the change

@ZeeD thanks for the PR

will merge after all tests pass

ZeeD commented 2 weeks ago

Thanks!

OpenAPITools / openapi-generator