OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
https://openapi-generator.tech
Apache License 2.0
20.6k stars 6.29k forks source link

build: use runtime scope for slf4j-simple log sink #18881

Closed jasonschroeder closed 3 weeks ago

jasonschroeder commented 4 weeks ago

Avoid leaking slf4j-simple as a dependency to openapi-generator consumers. Fixes: #14113

PR checklist

wing328 commented 3 weeks ago

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

jasonschroeder commented 3 weeks ago

Thanks for pointing that out, @wing328 ! I just fixed it and force-pushed :muscle:

wing328 commented 3 weeks ago

tested locally and the result is good

cc @OpenAPITools/generator-core-team