Closed filipe-silva closed 3 weeks ago
please PM me via Slack when you've time. thanks
Your additions to ApiClient.mustache use tabs. The rest of the document and all the other mustache templates use spaces. This is a regular comment instead of a review because my browser tends to freeze looking at large diffs :(
Tabs in some other places too. I recommend you turn on whitespace in your editor. If you're using vscode I've noticed you have to toggle the whitespace option to get them to show.
Please instead submit a small PR for each enhancement or bug fix so that it can be reviewed and merged more easily.
and looks like some of these enhancements were already done in the latest master. e.g. https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/csharp/modelGeneric.mustache#L401
my suggestion is to file new smaller PRs based on the latest master and we can get these merged quicker to keep the ball rolling.
massively improve csharp templates code
improved apiclient.mustache to keep it dry, sharing a single exec with Action<> delegate. improved api.mustache to keep it dry, used chain constructors, kept RequestOptions in a single method, set configuration with alias directive moved fqn types to using directive for cleaner code removed 'this' from variables/props that are redundant fix CSharpClientDeepObjectTest code is now DRY so count must only be one
Note: This is a PR based on #16990 with resolved merge conflicts, and up to date with master
PR checklist
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha @wing328