Closed andyland closed 3 months ago
lgtm
cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)
@andyland thanks for the fix, which has been merged.
please give it a try with the latest master or the snapshot version (published later via Travis CI workflow) to confirm the fix works as expected.
thanks again for your contribution
Fixes Issue 18940
This renames the
url
&path
variables tolocalVarURL
andlocalVarPath
to reduce the likelihood of collisions with parameters in the API request@dydus0x14
PR checklist
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)