search

OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
https://openapi-generator.tech
Apache License 2.0
21.81k stars 6.58k forks source link

[BUG] openapi-generator-cli doesnt validate empty enums #19585

Open nghiahsgs opened 5 months ago

nghiahsgs commented 5 months ago

⚠️ Important Notice

Please differentiate the bug

This repository is not responsible for the actual code generation. If you have problems with the code generation, please open the bug at OpenAPITools/openapi-generator.

Please also check if the bug is already known before you open a new bug.

🐛 Bug Report:

Describe the bug

A clear and concise description of what the bug is.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Create sample file test.yaml 
    
openapi: 3.0.3
info:
title: Simple API with Enum
description: A simple API to demonstrate enum usage in OpenAPI.
version: 1.0.0

paths: /items: get: summary: Get a list of items responses: '200': description: A list of items content: application/json: schema: type: array items: $ref: '#/components/schemas/Item'

components: schemas: Item: type: object properties: id: type: integer format: int64 example: 1 name: type: string example: "Sample Item" status: type: string enum: []


2. Run command validate `openapi-generator-cli validate test.yaml   `
3. It didn't show error about empty enum
4. It should be show error like this
![image](https://github.com/OpenAPITools/openapi-generator/assets/24955327/8c3f783a-631f-4781-b812-0e7faf3edd70)
![image](https://github.com/OpenAPITools/openapi-generator/assets/24955327/2fd89adb-7ec7-4ba1-8e1f-a442e2b36da1)

### Expected behavior
A clear and concise description of what you expected to happen.

### Screenshots
If applicable, add screenshots to help explain your problem.

### Operation System (please complete the following information):
 - OS: [e.g. Ubuntu ]
 - Version [e.g. 22]

### Package System (please complete the following information):
 - Version [e.g. 22]

### Additional context
Add any other context about the problem here.
AndieNguyenSotatek commented 5 months ago

I faced same issue

AndieNguyenSotatek commented 5 months ago

image

I have a question:

When I run the command openapi-generator-cli validate test.yaml, how can I find the logic for the validate function? I searched the source code but couldn't find any relevant function.

Thank you very much !

wing328 commented 1 month ago

When I run the command openapi-generator-cli validate test.yaml, how can I find the logic for the validate function? I searched the source code but couldn't find any relevant function.

it's done in swagger-parser.