search

OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
https://openapi-generator.tech
Apache License 2.0
21.23k stars 6.43k forks source link

[REQ][Dart] Refactor templates dirs: dart -> dart1-option and dart2 -> dart #3978

Open nickmeinhold opened 4 years ago

nickmeinhold commented 4 years ago

Is your feature request related to a problem? Please describe.

I found it confusing at first when I wanted to make modifications to the dart generator that the dart folder refers to dart1. Also it wasn't clear to me that there was a single dart generator with dart1 and dart2 options.

Describe the solution you'd like

I think logically it would make more sense to have the 'dart' templates using the current version of Dart and refactor the dart1 option into a folder called something like 'dart1-option'.

Describe alternatives you've considered

Remove the Dart1 option - personally I would be all for this but I get that there may be reasons to continue to support Dart 1.

nickmeinhold commented 4 years ago

@ircecho @swipesight @jaumard @wing328 do you think the project needs to continue to support Dart 1? If not I'll make a PR pulling out all the dart 1 stuff rather than work on the refactoring I described in this issue.

jaumard commented 4 years ago

Imho no need to continue supporting dart 1 :)