OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
https://openapi-generator.tech
Apache License 2.0
21.58k stars 6.52k forks source link

[BUG] go-server doesn't generate the same name of query param from the client #5896

Open ReSTARTR opened 4 years ago

ReSTARTR commented 4 years ago

Bug Report Checklist

Description
      parameters:
      - description: 'pet id'
        in: query
        name: pet_id
        required: true
        schema:
          format: int64
          type: integer
        style: form

When I defined query name with snake_case style, go-server generator generated code like this.

// api_default.go

// GetPet - 
func (c *DefaultApiController) GetPet(w http.ResponseWriter, r *http.Request) { 
    query := r.URL.Query()
    petId, err := parseIntParameter(query.Get("petId"))

But, from the same definition, go generator generates code like this.

// api_default.go

func (a *DefaultApiService) GetPet(ctx _context.Context, petId int64) (*_nethttp.Response, error) {
          : 
          :
    localVarQueryParams.Add("pet_id", parameterToString(petId, ""))

I want the server and the client to use the same name of query parameter "pet_id".

openapi-generator version

4.3.1-SNAPSHOT

OpenAPI declaration file content or url
openapi: 3.0.0
info:
  description: 'OpenAPI Petstore'
  title: OpenAPI Petstore
  version: 1.0.0
servers:
- description: The local server
  url: https://localhost:8080/{version}
paths:
  /pets:
    get:
      operationId: getPet
      parameters:
      - description: 'pet id'
        in: query
        name: pet_id
        required: true
        schema:
          format: int64
          type: integer
        style: form
      responses:
        "200":
          content: {}
          description: ""
Command line used for generation

for server

docker run --rm -v ${PWD}:/local openapitools/openapi-generator-cli:latest generate \
-i /local/openapi.yaml \
-g go-server -o /local/go-server

for client

docker run --rm -v ${PWD}:/local openapitools/openapi-generator-cli:latest generate \
-i /local/openapi.yaml \
-g go -o /local/go
Steps to reproduce
Related issues/PRs
Suggest a fix
auto-labeler[bot] commented 4 years ago

👍 Thanks for opening this issue! 🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

y14a commented 4 years ago

May this issue also occurs if specified uppercase in a name of a parameter definition.

A parameter definition excerpted from my OAS3 YAML file.

      - explode: false
        in: header
        name: X-MS-TOKEN-AAD-ID-TOKEN
        required: true
        schema:
          type: string
        style: simple

Generated code by using go-server generator

    xMSTOKENAADIDTOKEN := r.Header.Get("xMSTOKENAADIDTOKEN")