OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
https://openapi-generator.tech
Apache License 2.0
21.56k stars 6.52k forks source link

[BUG] [Spring] [Java] additionalModelTypeAnnotations not applied to enums #6055

Open ondrakucera opened 4 years ago

ondrakucera commented 4 years ago

Bug Report Checklist

Description

Option additionalModelTypeAnnotations isn't applied to enums.

openapi-generator version

4.3.0

OpenAPI declaration file content or url
swagger: "2.0"
info:
    title: Book
    version: 1.0.0
paths:
    /books:
        get:
            summary: Get books
            responses:
                200:
                    description: Successful response
                    schema:
                        type: array
                        items:
                            $ref: '#/definitions/Book'
definitions:
    Book:
        description: Book
        type: object
        properties:
            type:
                $ref: '#/definitions/BookType'
    BookType:
        description: Book type
        type: string
        enum:
            - HARDCOVER
            - PAPERBACK
            - ELECTRONIC
Command line used for generation
generate -g spring -p additionalModelTypeAnnotations=@Foo,hideGenerationTimestamp=true
generate -g java -p additionalModelTypeAnnotations=@Foo,hideGenerationTimestamp=true
Steps to reproduce

Generate the code and see the following:

Book.java:

...
/**
 * Book
 */
@ApiModel(description = "Book")
@Foo

public class Book   {
  ...
}

BookType.java

/**
 * Book type
 */
public enum BookType {
  ...
}
Related issues/PRs
Suggest a fix
auto-labeler[bot] commented 4 years ago

👍 Thanks for opening this issue! 🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

mutyasaisrikar commented 4 years ago

any update on this issue?

borsch commented 3 years ago

@ondrakucera @mutyasaisrikar please check this one https://github.com/OpenAPITools/openapi-generator/pull/8389

ondrakucera commented 3 years ago

@borsch Thanks. I agree with the general approach (a new option) but I can't really comment on the particular changes made in the commit.