search

OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
https://openapi-generator.tech
Apache License 2.0
21.82k stars 6.58k forks source link

PHP 7.1 end of life #6522

Closed ybelenko closed 3 years ago

ybelenko commented 4 years ago

PHP 7.1 reached end of life at 1 Dec 2019

End of life - A release that is no longer supported. Users of this release should upgrade as soon as possible, as they may be exposed to unpatched security vulnerabilities.

PHP: Supported Versions:

It seems that we need to change minimum PHP version to 7.2 in all php generators.

Current Requirements:

Generator PHP version
php client >= 7.2
Laravel server >= 7.2.5
Lumen server >= 7.2.5
Slim4 server >= 7.2
Symfony server >= 7.1.3
Ze-ph server >= 7.2

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon

ybelenko commented 4 years ago

@Articus I've seen your good work at #1902

Can you help with upgrade php-ze-ph server? I would do it myself, but there are no unit tests in php-ze-ph generator. We need to set PHP version to ^7.2 in composer.json: https://github.com/OpenAPITools/openapi-generator/blob/a4e42e1651b9f0f70ee56d40051803a73ac3c6fa/modules/openapi-generator/src/main/resources/php-ze-ph/composer.json.mustache#L8

and also here https://github.com/OpenAPITools/openapi-generator/blob/a4e42e1651b9f0f70ee56d40051803a73ac3c6fa/modules/openapi-generator/src/main/resources/php-ze-ph/README.md.mustache#L8

Packagist says that zendframework/zend-expressive package and few others are abandoned. We need to replace them with suggested packages.

Articus commented 4 years ago

Sure, but it would be better to move zendframework/zend-expressive replacement to another issue.

It is really simple to bump minimal PHP version to 7.2 - I am like 99%-sure that everything is still working, but it will be dutiful to run tests against current minor version of PHP 7.2. Can do that before next weekend.

Replacement of zendframework/zend-expressive is way more complex problem. All packages in zendframework namespace were renamed - https://getlaminas.org/blog/2020-03-09-transferring-zf-to-laminas.html (for example, Zend Expressive is now Laminas Mezzio). So it will require:

Articus commented 4 years ago

Checked generated stub on 7.4.7 , 7.3.19 and 7.2.31 - everything works fine (manual calls of generated methods and tests for PathHandler and DataTransfer versions used in stub).

So it is safe to bump minimal PHP version to 7.2. Though technically requirement "php": "^7.1" is still correct - stub works fine on 7.1.33 too :)

ybelenko commented 3 years ago

7.2 until 30 Nov 2020

Now we need to switch all PHP generators to 7.3 version, my god. 🤣

ybelenko commented 3 years ago

Closed in favour of #9200