[BUG] Spurious changes in `./bin/generate-samples.sh` output on Windows - Githubissues

OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)

https://openapi-generator.tech

Apache License 2.0

21.44k stars 6.49k forks source link

[BUG] Spurious changes in `./bin/generate-samples.sh` output on Windows #9400

Open hauntingEcho opened 3 years ago

hauntingEcho commented 3 years ago

Bug Report Checklist

[ X ] Have you provided a full/minimal spec to reproduce the issue?
[ N/A ] Have you validated the input using an OpenAPI validator (example)?
[ X ] Have you tested with the latest master to confirm the issue still exists?
[ X ] Have you searched for related issues/PRs?
[ X ] What's the actual output vs expected output?
[ ] [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

running the steps required as part of the PR template generates a bunch of junk on Windows, including:

filepath / vs \
alphabetically ordered files - / before vs after letters
/r/n vs /n

openapi-generator version

master branch

Generation Details

running the steps required as part of the PR template

Steps to reproduce

Open git-bash on Windows
git checkout master && git reset --hard && git clean -fdx to make sure you don't have any junk in your local repo
./mvnw clean package
./bin/generate-samples.sh to generate the samples
git diff to see the unwanted changes.

Expected output: nothing in the diff Actual output: very long, containing a lot of spurious changes. See attached tmp.txt

acouvreur commented 9 months ago

Having the same issue, generated files contains the CRLF line ending when running the script on windows.