search

OpenAPITools / openapi-generator

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)
https://openapi-generator.tech
Apache License 2.0
21.81k stars 6.58k forks source link

[REQ] Hide @ApiIgnore when using useSpringfox=false #9604

Open fvlad opened 3 years ago

fvlad commented 3 years ago

Is your feature request related to a problem? Please describe.

I'm using spring generator with springfox disabled (useSpringfox=false). However, the generated API still contains springfox ApiIgnore import reference. In my setup this is an unused import, since it is only required when you have vendorExtensions.x-spring-paginated or reactive enabled.

Describe the solution you'd like

I think we can duplicate this import inside both reactive and vendorExtensions.x-spring.paginated sections. This way it will not be present by default and will be defined if either of flags is enabled. It will be defined twice if both flags are true, but it doesn't look like an issue to me.

Describe alternatives you've considered

We can also simply hide the import itself with useSpringfox=false, but this will make an implicit dependency on this flag when we enable reactive or vendorExtensions.x-spring-paginated.

Additional context

I can make a PR if the solution is ok or would be glad to hear other options.

vemod commented 3 years ago

using openapi-generator-maven-plugin: 5.1.1

I use generateApiDocumentation=false and don't have springfox dependency in my classpath at all. the generated code contains import springfox.documentation.annotations.ApiIgnore; which results in class not found issue this was working fine in v4.3.1