OpenAPITools / sbt-openapi-generator

Other
27 stars 35 forks source link

bump openapi-generator and sbt version #45

Closed polentino closed 2 years ago

polentino commented 2 years ago

This PR aims to update openapi-generator to a more recent version, reason being: when compiling the generated code, this error appears

[error] [E1] openapi/src/main/scala/org/openapitools/client/core/JsonSupport.scala
[error]      object client is not a member of package sttp
[error]      did you mean client3?
[error]      L16: import sttp.client.json4s.SttpJson4sApi

this is due to the fact that the artifact was moved:

Note: This artifact was moved to:

com.softwaremill.sttp.client3 » core

I also bumped sbt version in order to be able to run it on macos, but that's not a hard requirement.

wing328 commented 2 years ago

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

polentino commented 2 years ago

Thanks, didn't notice that! I've update the commit and now should be fine.

polentino commented 2 years ago

bump 🙏

wing328 commented 2 years ago

Looks good to me. If no further feedback, I'll merge it in the coming weekend.

wing328 commented 2 years ago

cc @jrouly

wing328 commented 2 years ago

FYI. I've updated the openapi generator version to the latest via https://github.com/OpenAPITools/sbt-openapi-generator/commit/38c694423104f218ca3032382e8fff55b3ca606e