search

OpenAWE-Project / OpenAWE

A reimplementation of Remedy Entertainments Alan Wake Engine, in later iterations known as the Northlight Engine
GNU General Public License v3.0
159 stars 13 forks source link

Expand getNormalizedPath() to use throughout the project #24

Closed maaxxaam closed 1 year ago

maaxxaam commented 1 year ago

This PR should be able to resolve #15. getNormalizedPath() function, created during #21, now also removes "runtimedata\pc" and "d:/data" from the path.

maaxxaam commented 1 year ago

Ok, that's weird. CI have failed because vcpkg can't download bullet.

Nostritius commented 1 year ago

Just one thing, could you add unit tests for the path normalization and the replace function?

maaxxaam commented 1 year ago

Will do that once I figure out why tests for MSVC build fail - it's not visible in a PR now, but that came up when I ran a CI job on a fork.

Nostritius commented 1 year ago

Merged, Thanks