In https://github.com/OpenAdaptAI/OpenAdapt/pull/726, setting fix_moov=True makes videos recorded with video.py embedded in github comments start at 0:00 as expected, but video.extract_frames fails.
One possible solution involves comparing video_stream.time_base before and after move_moov_atom, computing the difference, and adjusting timestamps as necessary.
To Reproduce
Set fix_moov=False in finalize_video_writer
Create a recording: python -m openadapt.record foo
Try to visualize it: python -m openadapt.visualize
Describe the bug
In https://github.com/OpenAdaptAI/OpenAdapt/pull/726, setting
fix_moov=Truemakes videos recorded withvideo.pyembedded in github comments start at 0:00 as expected, butvideo.extract_framesfails.One possible solution involves comparing
video_stream.time_basebefore and aftermove_moov_atom, computing the difference, and adjusting timestamps as necessary.To Reproduce
fix_moov=Falseinfinalize_video_writerpython -m openadapt.record foopython -m openadapt.visualize