search

OpenAddressesUK / ernest

Open Addresses' "Ingester" software component
http://openaddressesuk.org/docs/
MIT License
1 stars 0 forks source link

Provenance data inconsistent with Turbot #28

Open JeniT opened 9 years ago

JeniT commented 9 years ago

The documentation in the README says to use processingScript. The documentation on the website says to use processing_scripts and processing_script. Which is correct or are they all acceptable?

JeniT commented 9 years ago

and the Turbot documentation says something similar to the Ernest website so there's inconsistency there too, hence the title of the issue as that's where I spotted it first

Floppy commented 9 years ago

My mistake, it should be processing_script. See https://github.com/OpenAddressesUK/ernest/blob/master/lib/jobs/create_address.rb#L45

Floppy commented 9 years ago

I think I got all javascripty. I should change userInput to user_input for consistency as well.

JeniT commented 9 years ago

I fixed the README, but there's still inconsistency. See the search for processing_scripts. Or do these mean different things?

Floppy commented 9 years ago

mmm, I'll have to check this when I can concentrate properly. /cc @pezholio

pezholio commented 9 years ago

Ah, I think processing_scripts here refers to a repo, whereas processing_script refers to a particular file and ref