OpenAddressesUK / hippodamus

Open Addresses' publishing scripts that create the downloadable versions of Open Addresses' database.
http://openaddressesuk.org/docs/
MIT License
0 stars 0 forks source link

'nilclass' among the address properties in the downloadable JSON version #2

Closed giacecco closed 9 years ago

giacecco commented 9 years ago

See the address below, taken from the downloadable full JSON version, likely produced using https://github.com/OpenAddressesUK/hippodamus/commit/8dc2f64b9c4c326831a4de973217b8ed4f8821c4 . I've picked it randomly. What's the nilclass property? In the best case scenario it's nothing, it the worst case scenario it is there in place of something else that is missing!

In case it wasn't obvious, do not delete the current versions on AWS while / when you have the new, fixed ones ready.

Thanks.

{
  "address" : {
    "url" : "http://alpha.openaddressesuk.org/addresses/7pW9D2",
    "sao" : "1ST FLOOR",
    "pao" : "36-40",
    "street" : {
      "name" : {
        "en" : [
          "THE STRAND"
        ],
        "cy" : []
      },
      "url" : "http://alpha.openaddressesuk.org/streets/no4MwN"
    },
    "nilclass" : {
      "name" : {
        "en" : [
          null
        ],
        "cy" : []
      },
      "url" : null
    },
    "locality" : {
      "name" : {
        "en" : [
          null
        ],
        "cy" : []
      },
      "url" : null
    },
    "town" : {
      "name" : {
        "en" : [
          "DERBY"
        ],
        "cy" : []
      },
      "url" : "http://alpha.openaddressesuk.org/towns/sGp6bi"
    },
    "postcode" : {
      "name" : {
        "en" : [
          "DE1 1BE"
        ],
        "cy" : []
      },
      "url" : "http://alpha.openaddressesuk.org/postcodes/Bty9pj"
    },
    "provenance" : {
      "activity" : {
        "executed_at" : "2014-12-01T15:26:12.720Z",
        "processing_scripts" : "https://github.com/OpenAddressesUK/distiller",
        "derived_from" : [
          {
            "type" : "Source",
            "urls" : [
              "http://ernest.openaddressesuk.org/addresses/689029"
            ],
            "downloaded_at" : "2014-12-01T15:26:12.720Z",
            "processing_script" : "https://github.com/OpenAddressesUK/distiller/tree/3de740587c878a18da85b1e95c957c575cde088a/lib/distil.rb"
          },
          {
            "type" : "Source",
            "urls" : [
              "http://alpha.openaddressesuk.org/postcodes/Bty9pj"
            ],
            "downloaded_at" : "2014-12-01T15:26:12.720Z",
            "processing_script" : "https://github.com/OpenAddressesUK/distiller/tree/3de740587c878a18da85b1e95c957c575cde088a/lib/distil.rb"
          },
          {
            "type" : "Source",
            "urls" : [
              "http://alpha.openaddressesuk.org/streets/no4MwN"
            ],
            "downloaded_at" : "2014-12-01T15:26:12.721Z",
            "processing_script" : "https://github.com/OpenAddressesUK/distiller/tree/3de740587c878a18da85b1e95c957c575cde088a/lib/distil.rb"
          },
          {
            "type" : "Source",
            "urls" : [
              "http://alpha.openaddressesuk.org/towns/sGp6bi"
            ],
            "downloaded_at" : "2014-12-01T15:26:12.721Z",
            "processing_script" : "https://github.com/OpenAddressesUK/distiller/tree/3de740587c878a18da85b1e95c957c575cde088a/lib/distil.rb"
          }
        ]
      }
    }
  }
}
pezholio commented 9 years ago

That shouldn't be there. It should be locality, but I don't think my tests caught the case when there is no locality. Will fix.

giacecco commented 9 years ago

Let me know when the new files are in place.