OpenAddressesUK / hippodamus

Open Addresses' publishing scripts that create the downloadable versions of Open Addresses' database.
http://openaddressesuk.org/docs/
MIT License
0 stars 0 forks source link

Why does the postcode property support multiple languages? #6

Closed giacecco closed 9 years ago

giacecco commented 9 years ago

Why does the postcode property support multiple languages? Moreover, the way I would read the record in the example below is that we only know the postcode in English but not its Welsh version :-/

{
  "address" : {
    "url" : "http://alpha.openaddressesuk.org/addresses/7pW9D2",
    "sao" : "1ST FLOOR",
    (...)
    "postcode" : {
      "name" : {
        "en" : [
          "DE1 1BE"
        ],
        "cy" : []
      },
      "url" : "http://alpha.openaddressesuk.org/postcodes/Bty9pj"
    },
    (...)
  }
}
pezholio commented 9 years ago

That's because it's an address part, and all address parts behave the same. It's probably not necessary for postcodes though

giacecco commented 9 years ago

I agree that the internally in our software it can be easier to manage all alphanumeric properties the same way, but as a user I would expect serialisations to cut the redundant parts of the data structure out, particularly if their semantics is arguable as in this case.

@JeniT what do you reckon, and do we want any fixes to this in Alpha or Beta?

pezholio commented 9 years ago

No, I totally agree, I think this is a bug

giacecco commented 9 years ago

Ok back to bug then. How complex is it to fix? Need to understand if we can get it done before soft-launch next week.

pezholio commented 9 years ago

Oh, dead easy. I'll do it now :+1: