OpenAero / main

Aerobatic sequence creation software
https://openaero.net
GNU General Public License v3.0
15 stars 7 forks source link

IAC Glider sequences are printed on CIVA forms #247

Closed djmolny closed 2 years ago

djmolny commented 3 years ago

To reproduce:

  1. Create a new sequence with class=Glider, rules=IAC, category=(any), program=(any)
  2. Insert a figure
  3. Select File -> Print/Save Forms
  4. Select Print/Save PDF
  5. Note that the right-hand column matches CIVA forms (Harm., Penalties, etc.)

Diagnosis:

SOLUTION: In both files, change the ternary test to: iacForms = (ruleName === 'iac' || ruleName === 'glider-iac') ? true : false;

djmolny commented 3 years ago

The info above refers to version 2021.1.9.

djmolny commented 3 years ago

Update: the user can work around this problem by selecting the option A/B/C forms in IAC style on the print dialog.

djmolny commented 3 years ago

Probably related: Form A for IAC Glider sequences does not display the word "Glider" anywhere, leading to confusion with Power sequences.

Attachment 1: The top of a CIVA Form A Glider sequence. Screenshot from 2021-08-16 08-57-22

Attachment 2: The top of an IAC Form A Glider sequence. Screenshot from 2021-08-16 09-00-21

OpenAero commented 3 years ago

Thanks for the information. I will look into it in September.

Op ma 16 aug. 2021 om 17:00 schreef DJ Molny @.***>:

Probably related: Form A for IAC Glider sequences does not display the word "Glider" anywhere, leading to confusion with Power sequences.

Attachment 1: The top of a CIVA Form A Glider sequence. [image: Screenshot from 2021-08-16 08-57-22] https://user-images.githubusercontent.com/835079/129584750-1e6e5264-222d-4580-8311-be54d8b50e1d.png

Attachment 2: The top of an IAC Form A Glider sequence. [image: Screenshot from 2021-08-16 09-00-21] https://user-images.githubusercontent.com/835079/129584870-84345869-c4b0-4bcd-a301-b3b2e9e78ff8.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenAero/main/issues/247#issuecomment-899581412, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXNLINCDXJ6PGTRSNTUSGLT5ER2PANCNFSM5AOPUHEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

bdkjones commented 3 years ago

This just tripped up a competitor heading to The Tequila Cup. It seems that the "A/B/C Forms in IAC Style" print option is automatically enabled for Power but not automatically enabled for Glider, even though in both cases the "rules" category is set to IAC.

OpenAero commented 2 years ago

Hi Brian,

Thanks for the info. I'll correct this. Update will probably be done sometime after the CIVA meeting, so I can also incorporate rule changes and new sequences from that.

Best regards, Ringo

Op wo 10 nov. 2021 om 17:51 schreef Bryan Jones @.***>:

This just tripped up a competitor heading to The Tequila Cup. It seems that the "A/B/C Forms in IAC Style" print option is automatically enabled for Power but not automatically enabled for Glider, even though in both cases the "rules" category is set to IAC.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenAero/main/issues/247#issuecomment-965538790, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXNLII22EVBFU7CMLOEBZDULKPI3ANCNFSM5AOPUHEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

OpenAero commented 2 years ago

Probably related: Form A for IAC Glider sequences does not display the word "Glider" anywhere, leading to confusion with Power sequences.

Attachment 1: The top of a CIVA Form A Glider sequence. Screenshot from 2021-08-16 08-57-22

Attachment 2: The top of an IAC Form A Glider sequence. Screenshot from 2021-08-16 09-00-21

Forgot to fix this in the latest OpenAero. Where should "Glider" go? Should it be in the Category box? So e.g.: Category: Glider Advanced

If so, should there also be "Power" for power sequences? E.g.: Category: Power Advanced

djmolny commented 2 years ago

Yes, I think that's a very good approach that eliminates any possible confusion.

OpenAero commented 2 years ago

Great! I'll update it like this.

OpenAero commented 2 years ago

Power or Glider added to forms from 2022.1.7.