search

OpenAero / main

Aerobatic sequence creation software
https://openaero.net
GNU General Public License v3.0
15 stars 7 forks source link

Improve filtering on the figure chooser #281

Closed OpenAero closed 10 months ago

OpenAero commented 1 year ago

The Figure Chooser currently has different types of filter applied: 1) Figures that match at the selected position are outlined green at the top and left, those that do not are faded out. 2) Figures that are not allowed according the rules are not shown by default, or shown with an orange outline when Hide illegal figs is selected off.

These different ways may cause confusion. Possibly a single system should be used. For example just filter options at the top:

Filter figures X Disallowed X Mismatched entry

jtbourke commented 1 year ago

I recommend you only have one type of highlighting. I think you should keep highlighting figures that have matching entry/exit lines for preceding/following figures, though for better clarity I think the highlight should be around the entire figure, not just a corner. Multiple colors of highlighting makes the purpose of the highlight less clear, and may not work for the colorblind. I also think the orange highlights are probably rarely seen because there is little reason for anyone to uncheck the "hide illegal figs" option.

If you agree to continue using highlighting for the entry/exit, then I think you only need one more option: [x] Hide illegal figures [x] Hide rarely used figures

I think both options should be on by default.

The "rarely used figures" are:

As you can see, there are many figures which can be hidden due to lack of interest. This is important because it will make it much easier to quickly scan the list for the much more common figures. The chance that someone wants to find a Vertical 8 is much smaller than the chance they are looking for a Humpty.

OpenAero commented 1 year ago

Good arguments! I mostly agree that this is the way to go for all points made.

Adding a "rarely used figures" certainly makes sense for the reasons you outline. However, deciding which figures are rarely used should be done with caution. For example, Q loops and quarter clovers (non-Aresti catalog) are regularly used in Sports competitions. A possible solution to this dilemma might be to let OpenAero scan all sequences in its library (which is easy). And preferably, to add many Unknown sequences to its database (which is more work, but can be useful for other features). Figures that don't occur at least twice (for example) could then be filtered out by "Hide rarely used figures"

jtbourke commented 1 year ago

Well if you think q loops are not “rarely used” then just leave them out of the list. I agree that they are used. Just rarely. It’s a judgment call.

It won’t be hard for people to toggle back and forth. You aren’t deleting them. Just limiting what people see in normal circumstances.

On Wed, Sep 20, 2023 at 12:07 PM OpenAero @.***> wrote:

Good arguments! I mostly agree that this is the way to go for all points made.

Adding a "rarely used figures" certainly makes sense for the reasons you outline. However, deciding which figures are rarely used should be done with caution. For example, Q loops and quarter clovers (non-Aresti catalog) are regularly used in Sports competitions. A possible solution to this dilemma might be to let OpenAero scan all sequences in its library (which is easy). And preferably, to add many Unknown sequences to its database (which is more work, but can be useful for other features). Figures that don't occur at least twice (for example) could then be filtered out by "Hide rarely used figures"

— Reply to this email directly, view it on GitHub https://github.com/OpenAero/main/issues/281#issuecomment-1728129075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2U7AFF7NX5D7GXNDNEWPTX3MPGRANCNFSM6AAAAAA454SQFE . You are receiving this because you commented.Message ID: @.***>

jtbourke commented 1 year ago

I just want to add that it doesn’t have to be perfect. Trying to scan all the sequences is a lot more work than just using your noggin to take a stab at what might be a good set of rarely used figures. If you have complaints about your choice you can reevaluate and change a line or two of code. Even if you scan sequences you may still have complaints.

On Wed, Sep 20, 2023 at 12:11 PM Jim Bourke @.***> wrote:

Well if you think q loops are not “rarely used” then just leave them out of the list. I agree that they are used. Just rarely. It’s a judgment call.

It won’t be hard for people to toggle back and forth. You aren’t deleting them. Just limiting what people see in normal circumstances.

On Wed, Sep 20, 2023 at 12:07 PM OpenAero @.***> wrote:

Good arguments! I mostly agree that this is the way to go for all points made.

Adding a "rarely used figures" certainly makes sense for the reasons you outline. However, deciding which figures are rarely used should be done with caution. For example, Q loops and quarter clovers (non-Aresti catalog) are regularly used in Sports competitions. A possible solution to this dilemma might be to let OpenAero scan all sequences in its library (which is easy). And preferably, to add many Unknown sequences to its database (which is more work, but can be useful for other features). Figures that don't occur at least twice (for example) could then be filtered out by "Hide rarely used figures"

— Reply to this email directly, view it on GitHub https://github.com/OpenAero/main/issues/281#issuecomment-1728129075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2U7AFF7NX5D7GXNDNEWPTX3MPGRANCNFSM6AAAAAA454SQFE . You are receiving this because you commented.Message ID: @.***>

OpenAero commented 11 months ago

I've implemented the features. I slightly changed the list of rarely used figures. Please check it at https://openaero.net/devel

jtbourke commented 11 months ago

I like it. I played around with a ui to collapse the filter area and give room for additional options:

[image: image.png]

Jim

On Mon, Nov 20, 2023 at 4:53 AM OpenAero @.***> wrote:

I've implemented the features. I slightly changed the list of rarely used figures. Please check it at https://openaero.net/devel

— Reply to this email directly, view it on GitHub https://github.com/OpenAero/main/issues/281#issuecomment-1818912806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2U7AC5JCXVGLND5K7J63LYFNADZAVCNFSM6AAAAAA454SQFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJYHEYTEOBQGY . You are receiving this because you commented.Message ID: @.***>

-- Jim Todd Bourke IAC President - visit iac.org Jim Bourke Airshows - visit jimbourke.com 50% of the people I know call me Jim, 50% call me Todd. Take your pick.

OpenAero commented 10 months ago

Improvement has been implemented in OpenAero 2024.1.3. In my opinion, the filter UI option is not needed until there are at least 3 filters available. Closing issue for now.